Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-2055] - Remove missingValueString tablesaw values #438

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Dec 19, 2024

Description

Story: BI-2055 - Remove missingValueString tablesaw values

Default tablesaw behavior silently converts certain values to an empty string when processing tables, which can lead to unexpected behavior when importing files in DeltaBreed. This follows up on work implemented in BI-1993 to also remove this silent conversion for N/A, NaN, *, and null values and update associated tests. Since before this card any of the aforementioned values would be converted to null, this revealed some unexpected behavior in downstream workflows processing said values, which this part of the card addressed.

Dependencies

tablesaw: bug/BI-2055 (should be merged into master before this card is tested to avoid a great deal of pain)

Testing

For both the new experiment and append/overwrite workflows

  • Upload a file that has the following values (N/A, NaN, *, null) for each ontology term scale class
    • Confirm that appropriate error appears for numerical, date, ordinal, and nominal scale classes when N/A, NaN, *, and null are observation inputs
    • Confirm that no error appears for cells with free text values with N/A, NaN, and *
    • Confirm that "'Null' is not a valid value" error appears for cells with free text value of null
  • Upload a file with just N/A, NaN, and * values for a free text ontology term
    • Confirm that import preview loads and displays correct values for free text terms
    • Complete upload and ensure that free text terms display in experiment and observations table

Smoke test other upload workflows as a sanity measure

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: _<please include a link to TAF run>_

@github-actions github-actions bot added the bug Something isn't working label Dec 19, 2024
@HMS17 HMS17 requested review from a team, davedrp and mlm483 and removed request for a team January 10, 2025 20:32
@HMS17 HMS17 marked this pull request as ready for review January 10, 2025 21:33
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

I left one suggested change to clean up a comment.

HMS17 and others added 2 commits January 15, 2025 17:08
Co-authored-by: mlm483 <128052931+mlm483@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants