Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cep is not a function no Angular 5 #112

Closed
rdorta opened this issue Mar 4, 2018 · 8 comments
Closed

Cep is not a function no Angular 5 #112

rdorta opened this issue Mar 4, 2018 · 8 comments
Labels
bug question

Comments

@rdorta
Copy link

rdorta commented Mar 4, 2018

Primeiramente parabéns pelo projeto.

Ao utilizar com Angular 5, após a instalação via npm:

Utilização:
import * as cepFunction from 'cep-promise'

cepFunction('18110-210').then(console.log);

ERRO:
ERROR TypeError: cepFunction is not a function
@lucianopf
Copy link
Member

Typescript man @claytonsilva, eu invoco vc! 😄

@claytonsilva
Copy link
Contributor

:D invocado, tá na minha roadmap do dia já :D

@gabrielggd
Copy link

Parabéns pelo projeto e pela atenção
Eu consegui fazer funcionar no Angular5 usando:
import * as cepPromise from 'cep-promise/dist/cep-promise-browser'

claytonsilva added a commit to claytonsilva/cep-promise that referenced this issue Mar 8, 2018
@claytonsilva
fix(typings): fix type for angular 5
8452f1f 
in issue BrasilAPI#112, we saw the problem with angular 5.

in my tests, i install angular 5 and rollback the definition without workarround
solved for default function microsoft/TypeScript#5073

and this back work, i think this worked because typescript can have a fix in recent version.
@claytonsilva claytonsilva mentioned this issue Mar 8, 2018
Closed
@claytonsilva
Copy link
Contributor

Pessoal fiz uns testes com angular 5 e parece que teve atualização do typescript que acabou resolvendo um velho problema.

Já mandei a pr pra ajustar a chamada do cep com typings mais arrumadinho
https://github.com/filipedeschamps/cep-promise/pull/113

@claytonsilva
Copy link
Contributor

@lucianopf malz demora :(

@lucianopf
Copy link
Member

Hahaha, rlx mano, aqui é open, contrib tem que vir quando tem tempo msm! 😂 👍

@lucianopf
Copy link
Member

A issue ainda é válida @rdorta ? 🤔
(não tive problemas utilizando a lib com a versão mais recente do TypeScript)

@rdorta
Copy link
Author

rdorta commented Feb 20, 2019

Confesso que não utilizei mais. Vou tentar reproduzir novamente

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rdorta @claytonsilva @lucianopf @gabrielggd