Skip to content

Commit

Permalink
Merge pull request #206 from krysalead/master
Browse files Browse the repository at this point in the history
fix: Remove hard coded strings when showing the showShareSheet
  • Loading branch information
aaustin authored Sep 15, 2016
2 parents ea6df31 + f25a972 commit 8e9c58a
Show file tree
Hide file tree
Showing 5 changed files with 158 additions and 162 deletions.
8 changes: 7 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,10 @@ testbed/plugins
testbed/hooks
node_modules
testbed/ul_web_hooks/
.installed
.installed
.gradle/
.idea/
cordova-ionic-phonegap-branch-deep-linking.iml
local.properties
out/
src/cordova-ionic-phonegap-branch-deep-linking.iml
28 changes: 22 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -382,11 +382,11 @@ Once you've created your `Branch Universal Object`, which is the reference to th
| KEY | TYPE | MEANING
| ------------------ | -------- | --------------------
| $fallback_url | `string` | Change the redirect endpoint for all platforms - so you don’t have to enable it by platform
| $desktop_url | `string` | Change the redirect endpoint on desktops
| $desktop_url | `string` | Change the redirect endpoint on desktops
| $android_url | `string` | Change the redirect endpoint for Android
| $ios_url | `string` | Change the redirect endpoint for iOS
| $ipad_url | `string` | Change the redirect endpoint for iPads
| $fire_url | `string` | Change the redirect endpoint for Amazon Fire OS
| $fire_url | `string` | Change the redirect endpoint for Amazon Fire OS
| $blackberry_url | `string` | Change the redirect endpoint for Blackberry OS
| $windows_phone_url | `string` | Change the redirect endpoint for Windows OS

Expand Down Expand Up @@ -441,15 +441,24 @@ The Branch iOS SDK includes a wrapper on the UIActivityViewController that will
| KEY | TYPE | MEANING
| ------------------ | -------- | --------------------
| $fallback_url | `string` | Change the redirect endpoint for all platforms - so you don’t have to enable it by platform
| $desktop_url | `string` | Change the redirect endpoint on desktops
| $desktop_url | `string` | Change the redirect endpoint on desktops
| $android_url | `string` | Change the redirect endpoint for Android
| $ios_url | `string` | Change the redirect endpoint for iOS
| $ipad_url | `string` | Change the redirect endpoint for iPads
| $fire_url | `string` | Change the redirect endpoint for Amazon Fire OS
| $fire_url | `string` | Change the redirect endpoint for Amazon Fire OS
| $blackberry_url | `string` | Change the redirect endpoint for Blackberry OS
| $windows_phone_url | `string` | Change the redirect endpoint for Windows OS

**shareText**: `string` - Custom share text
**localization**: `object` - Custom text to share (From version 2.1.17)

| KEY | TYPE | MEANING
| ------------------ | -------- | --------------------
| shareText | `string` | Content of the message by default: 'This stuff is awesome:'
| shareTitle | `string` | Title of the message by default: 'Check this out!'
| copyToClipboard | `string` | Copy to clipboard action button label by default: 'Copy'
| clipboardSuccess | `string` | Success message on copy to clipboard by default: 'Added to clipboard'
| more | `string` | More button by default: 'Show More'
| shareWith | `string` | Title of the sharing popup by default: 'Share With'

##### Usage
```js
Expand All @@ -462,7 +471,14 @@ branchUniversalObj.showShareSheet({
}, {
// put your control parameters here
"$desktop_url" : "http://desktop-url.com",
}, 'Custom share text: ');
}, {
"shareText": "This stuff is awesome: ",
"shareTitle": "Check this out!",
"copyToClipboard": "Copy",
"clipboardSuccess": "Added to clipboard",
"more": "Show More",
"shareWith": "Share With"
});
```

##### Share Sheet Callbacks
Expand Down
8 changes: 2 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"license": "MIT",
"scripts": {
"prerelease": "gulp prerelease",
"commit": "git-cz",
"semantic-release": "semantic-release pre && npm publish && semantic-release post"
"semantic-release": "semantic-release pre && npm publish && semantic-release post",
"commit": "git-cz"
},
"dependencies": {
"mkpath": "^1.0.0",
Expand All @@ -53,10 +53,6 @@
"gulp-eslint": "^3.0.1",
"gulp-jscs": "^4.0.0",
"gulp-sourcemaps": "^1.6.0",
"mkpath": "^1.0.0",
"node-version-compare": "^1.0.1",
"plist": "^1.2.0",
"semantic-release": "^4.3.5",
"wd": "^0.4.0"
},
"config": {
Expand Down
4 changes: 2 additions & 2 deletions plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ SOFTWARE.
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
id="io.branch.sdk"
version="2.1.16">
version="2.1.17">

<name>branch-cordova-sdk</name>
<description>Branch SDK Plugin</description>
<license>Apache 2.0</license>
<keywords>cordova,branch</keywords>
<repo>https://github.com/BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK.git</repo>
<issue>https://github.com/BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK/issues</issue>

<dependency
id="es6-promise-plugin"
url="https://github.com/vstirbu/PromisesPlugin.git">
Expand Down
Loading

0 comments on commit 8e9c58a

Please sign in to comment.