Fix words being split at special characters missing from list #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, sorry for the delay!! Thank you very much for the fix. I discover that regex in qt are different from the other because \w usually stand for [a-zA-Z0-9_], but in Qt it includes all the special character derived from it. |
Bramas
added a commit
that referenced
this pull request
Jan 9, 2016
Fix words being split at special characters missing from list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some special characters (ö, ß) were missing from the regex of word characters. After adding them the regex would probably still be incomplete, so I used \w instead as a more general solution.
