Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added TentOrGrassCaseRuleTests #688

Merged
merged 7 commits into from
Dec 15, 2023
Merged

added TentOrGrassCaseRuleTests #688

merged 7 commits into from
Dec 15, 2023

Conversation

Kevin-771
Copy link
Collaborator

@Kevin-771 Kevin-771 commented Nov 10, 2023 •
edited
Loading

Description

added tests to TentOrGrassCaseRuleTest
added comments to TentOrGrassCaseRuleTest

Closes #612

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kevin-771 Kevin-771 changed the base branch from master to dev November 10, 2023 21:43
@Kevin-771 Kevin-771 marked this pull request as ready for review November 14, 2023 21:48
@charlestian23 charlestian23 mentioned this pull request Dec 13, 2023
Merged
10 tasks
charlestian23
charlestian23 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good

@charlestian23 charlestian23 merged commit 14b0750 into Bram-Hub:dev Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlestian23 charlestian23 charlestian23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TEST] Test or Grass Test
2 participants
@Kevin-771 @charlestian23