add internet connection checker and handler #41
Conversation
|
Visit the preview URL for this PR (updated for commit 239ed67): https://brainiacwiz--pr41-mmpotulo-xtfkt25f.web.app (expires Mon, 06 May 2024 20:43:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: aff57accd7fb79ba1d7bf7e70bd8fcad77b0db3f |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mmpotulo28 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -3,12 +3,62 @@ import { getState, metaConnection } from './metamask.js'; | |||
|
|
|||
| class Navbar { | |||
| constructor() { | |||
| this.checkInternetConnection(); | |||
There was a problem hiding this comment.
suggestion (testing): Missing tests for the new checkInternetConnection method.
The PR introduces a new method checkInternetConnection which handles internet connectivity checks and UI updates. It's crucial to ensure this functionality works as expected under different scenarios (online, offline, transitioning between states). Please add unit tests to verify the behavior of this method, including edge cases such as rapid switching between online and offline states.
No description provided.