Add fontawesome script to index.html, create getAccount.js file, upda… #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te truffle-config.js for celo network, and update dependencies in package.json
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mmpotulo28 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
+1
to
+18
| // get cell account and pprivatekey | ||
| // return account and privatekey | ||
| // account: string | ||
| // privatekey: string | ||
| // return: {account: string, privatekey: string} | ||
| const Web3 = require('web3'); | ||
| const web3 = new Web3( | ||
| new Web3.providers.HttpProvider('http://alfajores-forno.celo-testnet.org'), | ||
| ); | ||
|
|
||
| function getAccount() { | ||
| let account = '0x' + web3.eth.accounts.create().address; | ||
| let privatekey = web3.eth.accounts.create().privateKey; | ||
| let mnemonic = web3.eth.accounts.create().mnemonic; | ||
| return { account: account, privatekey: privatekey, mnemonic: mnemonic }; | ||
| } | ||
|
|
||
| console.log(getAccount()); |
There was a problem hiding this comment.
🚨 issue (security): Review the security implications of generating keys in client-side code.
Generating keys on the client-side can expose sensitive information. Consider server-side generation and secure transmission methods.
| function getAccount() { | ||
| let account = '0x' + web3.eth.accounts.create().address; | ||
| let privatekey = web3.eth.accounts.create().privateKey; | ||
| let mnemonic = web3.eth.accounts.create().mnemonic; |
There was a problem hiding this comment.
suggestion (code-quality): Prefer object destructuring when accessing and using properties. (use-object-destructuring)
Suggested change
| let mnemonic = web3.eth.accounts.create().mnemonic; | |
| let {mnemonic} = web3.eth.accounts.create(); |
Explanation
Object destructuring can often remove an unnecessary temporary reference, as well as making your code more succinct.From the Airbnb Javascript Style Guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te truffle-config.js for celo network, and update dependencies in package.json