Charles #16
Charles #16
Conversation
Merge pull request #2 from CPUT-DEVS/charles
update project structure
and a login.html and styleAuth.css to support the html files
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @CharlesLedwaba - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| <label for="terms">I agree to these <a href = "#">Terms & Conditions </a> </label> | ||
|
|
||
| </div> | ||
| <button type="submit">Sign Up</button> |
There was a problem hiding this comment.
issue (bug_risk): Button placement outside form may cause submission issues.
Consider moving the 'Sign Up' button inside the
tags to ensure proper form submission behavior.| </div> | ||
|
|
||
| </form> | ||
| <button type="submit">Sign Up </button> |
There was a problem hiding this comment.
issue (typo): Incorrect button label in login form.
The button in the login form is labeled 'Sign Up' instead of 'Log in'. This should be corrected to avoid user confusion.
| @@ -0,0 +1,87 @@ | |||
| @import url('https://fonts.googleapis.com/css2?family=Poppins:wght@400;600&display=swap'); | |||
There was a problem hiding this comment.
suggestion (performance): Consider local font hosting for performance and reliability.
Using an external link for fonts can introduce dependencies on third-party servers. Hosting fonts locally might improve load times and reliability.
| <label for="confirmPassword">Confirm Password:</label> | ||
| <input type="password" id="confirmPassword" name="confirmPassword" required> |
There was a problem hiding this comment.
suggestion (code_refinement): No client-side password confirmation logic.
While the form includes a field for confirming the password, there's no visible client-side logic to verify that the two passwords match before submission. Implementing this could improve user experience by catching mismatches before submission.
No description provided.