Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for online access when drawing panels #590

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

BradyAJohnston
Copy link
Owner

Adds a check that disables the panel and displays a warning for the wwPDB and AlphaFold download panels if networking disabled.

image

@BradyAJohnston BradyAJohnston linked an issue Sep 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (bb35110) to head (190a2c9).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
molecularnodes/entities/molecule/ui.py 9.09% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
- Coverage   71.73%   71.54%   -0.20%     
==========================================
  Files          50       50              
  Lines        4143     4157      +14     
==========================================
+ Hits         2972     2974       +2     
- Misses       1171     1183      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyAJohnston BradyAJohnston merged commit c2d85aa into main Sep 5, 2024
4 of 6 checks passed
@BradyAJohnston BradyAJohnston deleted the 573-online-access branch September 5, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add-on needs to respect online access permissions
1 participant