update assembly node #517
Merged
update assembly node #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaks the assembly node to discard data points that have a chain_id greater than the number of instances. Assembly information that comes from the files sometimes include chain IDs which don't appear in the actual file. This removes them when instancing to not double up the assemblies.
Properly polls for the biological assembly operator. Updates node creation to return existing nodes and existing data objects.
update bio assembly documentation to mention the need to set material again when using assembly node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks the assembly node to discard data points that have a chain_id greater than the number of instances.
Assembly information that comes from the files sometimes include chain IDs which don't appear in the actual file. This removes them when instancing to not double up the assemblies.