Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(levelPopup): Version 1 terminée #25

Merged
merged 11 commits into from
Feb 17, 2024
Merged

feat(levelPopup): Version 1 terminée #25

merged 11 commits into from
Feb 17, 2024

Conversation

sologames7
Copy link
Collaborator

@sologames7 sologames7 commented Nov 20, 2023

🤔 Why?

We needed to have a context to select the knowlegde level of the user to propose best content accordingly

💻 How?

created a context for the popup
created button component(to open popup)
created popup compoenent
created a component that use both previous component for them to work
added a page to see the component and test it.

✅ How to validate this PR?

go to page /levelSelection
Can see choice button
Can click on it
A form should apear
Should be able to select 1 lvl (Beginner, Intermediate and Advenced)
Button to close the choice popup

app/layout.tsx Outdated Show resolved Hide resolved
app/levelSelection/page.tsx Outdated Show resolved Hide resolved
src/components/LevelChoice/LevelPopup/LevelPopup.tsx Outdated Show resolved Hide resolved
src/components/LevelChoice/LevelPopup/LevelPopup.tsx Outdated Show resolved Hide resolved
src/components/LevelChoice/levelChoice.tsx Outdated Show resolved Hide resolved
src/components/LevelChoice/levelChoice.tsx Outdated Show resolved Hide resolved
src/components/LevelChoice/levelChoice.tsx Outdated Show resolved Hide resolved
src/context/LevelChoiceContext.tsx Outdated Show resolved Hide resolved
src/context/LevelChoiceContext.tsx Outdated Show resolved Hide resolved
@Boyadjie
Copy link
Owner

Il faudra aussi addapter la selection pour gérer le niveau ET l'objectif de voyage

@sologames7 sologames7 changed the title levelPopupSelection v1 Done feat(levelPopup): Version 1 terminée Dec 19, 2023
@Boyadjie
Copy link
Owner

les modifications demandées faites, tu peux les resolves quand elles sont finies, ça permet d'y voire plus claire et pour toi de savoir ce qu'il te reste a faire

Copy link
Owner

@Boyadjie Boyadjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il manque pas mal de choses encore :

  • Choix de l'objectif de voyage en plus du niveau
  • Affichage des choix
  • Fermeture de la popup quand on fait un choix

Je comprend pas, il y a les deux textes mais une seule selection :
image

@Boyadjie Boyadjie self-assigned this Jan 16, 2024
@Boyadjie Boyadjie self-requested a review January 22, 2024 14:19
@Boyadjie Boyadjie merged commit 88e26c7 into main Feb 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants