New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zeusHC - Fill Full Crew #621

Merged

PabstMirror merged 1 commit into master from fixMissingCrew

Jan 7, 2025

Contributor

lambdatiger commented Jan 2, 2025 •

edited

Loading

This PR replaces part of the potato_zeusHC_fnc_createCrew function to include all crew created when a vehicle is placed through the editor. i.e.,

Vodniks now spawn with both gunners
CUP BMP-3s spawn with both side gunners

Other notes:

In limited testing, the new method for creating the _crew array appears to be performant than the current method, we could cache if needed.
Unsure if this causes issues with effective commander, but didn't find any during limited testing.


          Replaced method for finding crew positions with config lookup

e3d9d39

PabstMirror approved these changes

View reviewed changes

PabstMirror added this to the v1.3.50 milestone

PabstMirror merged commit 218012f into master

1 check passed

PabstMirror deleted the fixMissingCrew branch

January 7, 2025 04:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet