assingGear - Selectable "No optic" and Fixed List #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCandianVendingMachine
approved these changes
Dec 5, 2024
I use # by default, do you want it to be select? Originally I had it as |
|
i dont care about it, just wanted to know if i had a blindspot |
PabstMirror
approved these changes
Dec 8, 2024
|
I've been trying to avoid changing default behavior since I know some people like hiding the current optic. I think your modification helps make it a bit clearer which is current and we could get rid of it, let me do a quick "survey" and we can cut it out if there's no opposition. |
|
Alright based on feedback I'll remove the option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a no optic option when custom optics are allowed and provides a CBA option to not hide the current optic from hte list.