Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Briefing - Make ORBAT Updatable and Trigger a Update on Safe Start Ending #595

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

lambdatiger
Copy link
Contributor

@lambdatiger lambdatiger commented Nov 7, 2024

This PR does what the name says, it finds the "ORBAT" diary entry (or entries) if a unit has it and replaces it, or adds one if a unit doesn't. This also allows the uiSleep time to be variable.

@lambdatiger
Copy link
Contributor Author

Anyone know if there's a reason to use vehicle _x vs _x? I changed it to the latter here and there must have been a reason at some point: 29684ac

@PabstMirror
Copy link
Contributor

not sure, maybe a long time ago we used to put vic crews into their vics at the start
and the idea was it would show the tank for tank crews?

either way, the change is fine as it's more important to show the specific role

@PabstMirror PabstMirror added this to the v1.3.49 milestone Nov 12, 2024
@PabstMirror PabstMirror merged commit b454871 into master Nov 13, 2024
1 check passed
@PabstMirror PabstMirror deleted the updatable-ORBAT branch November 13, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants