Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a faux KAC LAMG #590

Merged
merged 12 commits into from
Nov 17, 2024
Merged

Conversation

AChesheireCat
Copy link
Contributor

Adds a separate version of the vanilla Mk200 (Stoner 99 LMG) that's in 5.56 with lower recoil, replicating the Knights' Armament Company Light Assault Machine Gun.

Adds a separate version of the vanilla Mk200 (Stoner 99 LMG) that's in 5.56 with lower recoil.
@AChesheireCat AChesheireCat self-assigned this Oct 24, 2024
@PabstMirror PabstMirror added this to the v1.3.49 milestone Oct 25, 2024
Copy link
Contributor

@lambdatiger lambdatiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work in game and my only request is related to formatting.

Optional:
It would be nice to move all of the "faux" weapons to a new component, so maybe using something like potato_lmg_LAMG instead of GVAR(LAMG) would help out.

addons/miscFixes/fauxLAMG/CfgWeapons.hpp Outdated Show resolved Hide resolved
addons/miscFixes/fauxLAMG/CfgWeapons.hpp Outdated Show resolved Hide resolved
addons/miscFixes/fauxLAMG/CfgWeapons.hpp Outdated Show resolved Hide resolved
- Makes the CUP 100rnd TE4 magazines default for the weapon.
@AChesheireCat
Copy link
Contributor Author

Optional: It would be nice to move all of the "faux" weapons to a new component, so maybe using something like potato_lmg_LAMG instead of GVAR(LAMG) would help out.

Yeah, I was thinking the same thing tbh. I probably won't do it in this PR, but I'll start working on breaking out the three current faux weapons out into their own top-level addon to prevent unnecessary cluttering of MiscFixes. Good call!

@lambdatiger
Copy link
Contributor

I didn't end up sending you a quick example here and just did it, feel free to adjust the tail and other sounds to make it at the correct levels (I toned them down because it has some loud, harsh high frequency components I don't think are good on the ears to listen to full auto).

Changed the classname from GVAR(LAMG) to a permanent "potato_lmg_LAMG" in order to prevent classname changes for when this gets rebased to the new customGear addon.
Copy link
Contributor

@lambdatiger lambdatiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes were made, I think it works well for what the goal is.

@PabstMirror
Copy link
Contributor

I think we'll merge #594 first and then update this?

AChesheireCat and others added 6 commits November 12, 2024 16:06
Swapped the sounds from the vanilla SDAR to the JSRS SDAR firing sound (sorry Lambda, I couldn't tweak it to something that I liked...)
Following classname standardization
@PabstMirror
Copy link
Contributor

I split the c7 off to it's own sub-addon
it requires cup so it's nice to be seperated

@PabstMirror PabstMirror merged commit dedd037 into BourbonWarfare:master Nov 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants