Simplify lookup, browse and search functions #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
force-pushed
the
simplify-lookup
branch
from
7772bcf to
e249935
Compare
Borewit
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Borewit
force-pushed
the
simplify-lookup
branch
2 times, most recently
from
44413a8 to
664b49b
Compare
|
If you are happy with this one @Haschikeks , I like to merge it. |
Haschikeks
reviewed
Nov 18, 2023
Borewit
force-pushed
the
simplify-lookup
branch
2 times, most recently
from
f00f011 to
7e73e3b
Compare
Borewit
force-pushed
the
simplify-lookup
branch
from
7e73e3b to
28b3921
Compare
Haschikeks
approved these changes
Nov 20, 2023
Very true. Thanks for your review @Haschikeks, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove specific search function in favor of a single typed function:
mbApi.browseArtist(query)withmbApi.browse('artist', query)mbApi.lookupArtist('ab2528d9-719f-4261-8098-21849222a0f2')withmbApi.lookup('artist', 'ab2528d9-719f-4261-8098-21849222a0f2')mbApi.searchArtist({query: 'Stromae'})withmbApi.search('artist', {query: 'Stromae'})Resolves #822