Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for browse API #405

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Add support for browse API #405

merged 1 commit into from
Jul 26, 2022

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Mar 1, 2022 •
edited
Loading

Implements #2

  • Area
    • Implementation
    • Unit tests
    • Documentation
  • Artist
    • Implementation
    • Unit tests
    • Documentation
  • Collection
    • Implementation
    • Unit tests
    • Documentation
  • Event
    • Implementation
    • Unit tests
    • Documentation
  • Instrument
    • Implementation
    • Unit tests
    • Documentation
  • Label
    • Implementation
    • Unit tests
    • Documentation
  • Place
    • Implementation
    • Unit tests
    • Documentation
  • Recording
    • Implementation
    • Unit tests
    • Documentation
  • Release
    • Implementation
    • Unit tests
    • Documentation
  • Release Group
    • Implementation
    • Unit tests
    • Documentation
  • Series
    • Implementation
    • Unit tests
    • Documentation
  • Work
    • Implementation
    • Unit tests
    • Documentation
  • URL
    • Implementation
    • Unit tests
    • Documentation

@Borewit Borewit added enhancement New feature or request API Change labels Mar 1, 2022
@Borewit Borewit self-assigned this Mar 1, 2022
@Borewit Borewit marked this pull request as draft March 1, 2022 21:52
@Borewit Borewit force-pushed the api-browse-support branch 3 times, most recently from 4a80297 to 14c5feb Compare March 2, 2022 20:45
@Borewit Borewit mentioned this pull request Jul 11, 2022
Closed
@Borewit Borewit force-pushed the api-browse-support branch from 14c5feb to 538ac43 Compare July 24, 2022 16:30
@Borewit
Copy link
Owner Author

Borewit commented Jul 24, 2022

Can you please review this one @Haschikeks? I made total mess in this PR, as changed much more then just adding the browse functions, causing a lot of merge conflicts.

As may have deleted useful changes as well while rebasing, I stored the original branch here: backup/api-browse-support.

I did send you an invite to become a collaborator, which now expired. I you want me to send you another invite, just let me know.

@Borewit Borewit marked this pull request as ready for review July 24, 2022 16:51
@Borewit Borewit force-pushed the api-browse-support branch 4 times, most recently from 325eda0 to ea83cb1 Compare July 26, 2022 15:21
@lgtm-com
Copy link

lgtm-com bot commented Jul 26, 2022

This pull request introduces 1 alert when merging ea83cb1 into 8e1e546 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@Borewit Borewit force-pushed the api-browse-support branch from ea83cb1 to 82e614b Compare July 26, 2022 15:28
@Borewit Borewit force-pushed the api-browse-support branch from 82e614b to 19236b2 Compare July 26, 2022 15:29
@Borewit Borewit merged commit 27c9d37 into master Jul 26, 2022
@Borewit Borewit deleted the api-browse-support branch July 26, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
API Change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Borewit