Make botAccount config property optional

Borewit · Mar 31, 2024 · e09c8ee · e09c8ee
1 parent b40ff3b
commit e09c8ee
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/lib/musicbrainz-api.ts b/lib/musicbrainz-api.ts
@@ -134,7 +134,7 @@ export type IFormData = {[key: string]: string | number};
 const debug = Debug('musicbrainz-api');
 
 export interface IMusicBrainzConfig {
-  botAccount: {
+  botAccount?: {
     username?: string,
     password?: string
   },
@@ -167,8 +167,7 @@ export interface ISessionInformation {
 export class MusicBrainzApi {
 
   public readonly config: IMusicBrainzConfig = {
-    baseUrl: 'https://musicbrainz.org',
-    botAccount: {}
+    baseUrl: 'https://musicbrainz.org'
   };
 
   private rateLimiter: RateLimitThreshold;
@@ -358,8 +357,8 @@ export class MusicBrainzApi {
 
   public async login(): Promise<boolean> {
 
-    assert.ok(this.config.botAccount.username, 'bot username should be set');
-    assert.ok(this.config.botAccount.password, 'bot password should be set');
+    assert.ok(this.config.botAccount?.username, 'bot username should be set');
+    assert.ok(this.config.botAccount?.password, 'bot password should be set');
 
     if (this.session && this.session.loggedIn) {
       for (const cookie of await this.getCookies(this.options.prefixUrl as string)) {
@@ -429,8 +428,8 @@ export class MusicBrainzApi {
 
     formData.csrf_session_key = this.session.csrf.sessionKey;
     formData.csrf_token = this.session.csrf.token;
-    formData.username = this.config.botAccount.username;
-    formData.password = this.config.botAccount.password;
+    formData.username = this.config.botAccount?.username;
+    formData.password = this.config.botAccount?.password;
     formData.remember_me = 1;
 
     const response = await got.post(`${entity}/${mbid}/edit`, {

diff --git a/test/test-musicbrainz-api.ts b/test/test-musicbrainz-api.ts
@@ -58,7 +58,6 @@ async function makeSearchApi(): Promise<MusicBrainzApi> {
   return new MusicBrainzApi({
 
     baseUrl: 'https://musicbrainz.org',
-    botAccount: {},
 
     /**
      * Enable proxy, like Fiddler