Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quizzes are not displayed #88

Merged

Conversation

StackSurfer
Copy link
Contributor

@StackSurfer StackSurfer commented Nov 18, 2023

Description

Quizzes will now be displayed in the lecture if the lecture has quizzes.

After talking to @Maschga, I'll be taking over #43 since it's closely related. Instead of conditionally rendering the buttons, I'll provide more information about whether the course has any more quizzes and where the next one is located, or inform them that there are no more quizzes in this course.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Translation updates (fix/improve or add new translations)

Fixes Bootstrap-Academy/Bootstrap-Academy#63
Fixes Bootstrap-Academy/Bootstrap-Academy#49

My Bootstrap Academy username: Joggl

@StackSurfer StackSurfer mentioned this pull request Nov 18, 2023
4 tasks
@Defelo Defelo self-requested a review November 20, 2023 19:47
@Defelo Defelo self-assigned this Nov 20, 2023
Copy link
Member

@Defelo Defelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the quizzes seem to always load now, but the challenges do not anymore (e.g. here:
image

Also the counts are'nt correct (here):
image

@Defelo Defelo assigned StackSurfer and unassigned Defelo Nov 20, 2023
@Defelo Defelo added the blocker label Nov 20, 2023
@StackSurfer
Copy link
Contributor Author

StackSurfer commented Nov 20, 2023

Ok, the quizzes seem to always load now, but the challenges do not anymore (e.g. here: image

Also the counts are'nt correct (here): image

For the quizzes, the issue might be resolved in #89. However, I am unsure about the challenges. I couldn't find any challenge responses or create a new challenge.
Which course did you look up the challenges in? Does this course definitely have challenges? If so, I can take a look at them as well. The only question would be where to do this, since #89 is also closely related to all of this.

@Defelo
Copy link
Member

Defelo commented Nov 20, 2023

There should be two challenges in the first lecture of the Medienkompetenz course: https://bootstrap-academy-frontend.pages.dev/courses/medienkompetenz/watch?section=section&lecture=zWHWXOhcyeE&skillID=start&subSkillID=medienkompetenz

@StackSurfer StackSurfer mentioned this pull request Nov 21, 2023
4 tasks
@StackSurfer
Copy link
Contributor Author

Good Evening @Defelo.
I think it should be fine now.

  • Toggle buttons display the number of Quizzes and Challenges in the current lecture.
  • Quizzes and Challenges should be displayed correctly.
  • I also added an indicator for Quizzes in upcoming/unseen lectures.

@StackSurfer StackSurfer requested a review from Defelo November 26, 2023 20:27
@StackSurfer
Copy link
Contributor Author

I ran into an Issue that would require me to look into API-Doc's. Unfortunately I cannot find/access them, probably because the Migration I guess?

@Defelo
Copy link
Member

Defelo commented Dec 28, 2023

Yes, the api docs are now available at https://api.test.bootstrap.academy/. This is also documented in the Bootstrap-Academy readme

@StackSurfer StackSurfer marked this pull request as draft December 29, 2023 13:23
@StackSurfer StackSurfer marked this pull request as ready for review January 5, 2024 07:54
@StackSurfer
Copy link
Contributor Author

Hello @Defelo!
Sry that it took so long. There was a big Conflict with the Matchings-feature that lead into some bugs. I think this pr might be fine now.

@Defelo Defelo assigned Defelo and unassigned StackSurfer May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Preview deployed to https://3394c4fd.academy-preview.pages.dev (total size: 11M)

@Defelo Defelo merged commit 2d8229d into Bootstrap-Academy:develop May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quizzes are not displayed on the "Watch Course" page Hide Quiz/Challenge buttons if there is none
2 participants