Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze ebcc to 1.5.0 #183

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Freeze ebcc to 1.5.0 #183

merged 1 commit into from
Dec 5, 2024

Conversation

obackhouse
Copy link
Contributor

Freezes the ebcc version until #182 is addressed

@obackhouse obackhouse requested a review from basilib November 30, 2024 11:17
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.45%. Comparing base (d3527ed) to head (78bffa8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   71.45%   71.45%   -0.01%     
==========================================
  Files         156      156              
  Lines       20876    20876              
  Branches     2951     2951              
==========================================
- Hits        14917    14916       -1     
- Misses       5092     5093       +1     
  Partials      867      867              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obackhouse
Copy link
Contributor Author

Note that ebcc 1.6.0 is now released, so Vayesta tests will fail until this is approved

Copy link
Contributor

@basilib basilib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hopefully we can make a more complete fix to maintain compatibility soon.

@basilib basilib merged commit b0edcca into master Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants