Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements and bug fixes in bc-explorer tui #1343

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

YoshihitoAso
Copy link
Member

@YoshihitoAso YoshihitoAso commented Mar 2, 2023

  • Some IDE environments were causing module import errors, so I reviewed the import way.
  • Fixed some minor bugs.

@YoshihitoAso YoshihitoAso marked this pull request as ready for review March 2, 2023 16:11
Comment on lines 183 to 185
##################################################
# Key biding
##################################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“binding” typo I think.

@purplesmoke05
Copy link
Member

purplesmoke05 commented Mar 3, 2023

Appending path in connector can also be removed.
This part of appending path seems impossible to remove...

import os
import sys
from dataclasses import asdict
from typing import Any
from aiohttp import ClientSession
from cache import AsyncTTL
path = os.path.join(os.path.dirname(__file__), "../../../../")
sys.path.append(path)

Copy link
Member

@purplesmoke05 purplesmoke05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This completely solved IDE import problems🤯
Awesome.

@purplesmoke05
Copy link
Member

approved including 6ab5b53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants