Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buyer/seller personal information to DvP delivery data #665

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

YoshihitoAso
Copy link
Member

  • There is a need to refer to personal information registered for issuers for buyers/sellers in DVP settlement.
  • Add personal information to the API response items of delivery data.

@YoshihitoAso YoshihitoAso self-assigned this Jul 25, 2024
@YoshihitoAso YoshihitoAso added the enhancement New feature or request label Jul 25, 2024
@YoshihitoAso YoshihitoAso marked this pull request as ready for review July 25, 2024 12:26
Comment on lines +241 to +243
any_of: list | None = _get(schema, "anyOf")
if any_of is not None:
schema["anyOf"] = sorted(any_of, key=lambda x: x["$ref"])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When generating an OpenAPI document, there was an issue where the order of the anyOf list changed every time, so I fixed it.

@YoshihitoAso YoshihitoAso changed the title Add buyer/seller personal information to delivery data Add buyer/seller personal information to DvP delivery data Jul 25, 2024
Copy link
Member

@purplesmoke05 purplesmoke05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshihitoAso YoshihitoAso merged commit 6e76dbd into dev-24.9 Jul 26, 2024
6 checks passed
@YoshihitoAso YoshihitoAso deleted the add-personal-info branch July 26, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants