Separate functions that are not related to the issuer #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshihitoAso
commented
Jul 24, 2024
Comment on lines
+121
to
+128
| if DVP_AGENT_FEATURE_ENABLED: | ||
| app.include_router(settlement_agent.router) | ||
|
|
||
| if BC_EXPLORER_ENABLED: | ||
| app.include_router(bc_explorer.router) | ||
|
|
||
| if FREEZE_LOG_FEATURE_ENABLED: | ||
| app.include_router(freeze_log.router) |
There was a problem hiding this comment.
APIs are loaded according to the environment variable settings.
YoshihitoAso
commented
Jul 24, 2024
Comment on lines
70
to
81
| issuer_address: str = Header(...), | ||
| ): | ||
| """List of DVP delivery""" | ||
| stmt = select(IDXDelivery).where( | ||
| IDXDelivery.exchange_address == exchange_address, | ||
| stmt = ( | ||
| select(IDXDelivery) | ||
| .join(Token, Token.token_address == IDXDelivery.token_address) | ||
| .where( | ||
| and_( | ||
| IDXDelivery.exchange_address == exchange_address, | ||
| Token.issuer_address == issuer_address, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Filter only data related to tokens issued by the issuer set in the header.
|
From the Agent's perspective, there was a problem with referencing the delivery list, so a new API was added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Change to store issuer-related and unrelated APIs in separate directories
app > routers > issuer | misc
2. Add environment variables
FREEZE_LOG_FEATURE_ENABLED: Set if you want to use FRREZE-LOG features.DVP_AGENT_FEATURE_ENABLED: Set if you want to use DVP Paying Agent features.3. Change to DVP-related APIs
app.routers.issuer.settlement_issuer.pyapp.routers.misc.settlement_agent.pyGET: /settlement/dvp/{exchange_address}/deliveriesGET: /settlement/dvp/{exchange_address}/delivery/{delivery_id}