Add transaction compression mode bulkTransfer #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshihitoAso
commented
Jan 14, 2024
| return value | ||
|
|
||
|
|
||
| EthereumAddress = Annotated[str, WrapValidator(ethereum_address_validator)] |
There was a problem hiding this comment.
I also improved Address validation.
YoshihitoAso
commented
Jan 14, 2024
| # Split the original transfer list into sub-lists | ||
| chunked_transfer_list: list[list[BulkTransfer]] = list( | ||
| self.__split_list(list(transfer_list), 100) | ||
| ) |
There was a problem hiding this comment.
When executing bulkTransfer, the uploaded list is split into 100 items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bulkTransferof token contracts.When using "transaction compression mode", transfer list must meet the following conditions:
token_addressmust be the same.from_addressmust be the same.from_addressandissuer_addressmust be the same.✏️ Note: The current implementation does not check whether the balance is sufficient for the amount transferred.