New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floating-point arithmetic in share params validation #567

Merged

purplesmoke05 merged 2 commits into dev-23.12 from fix/#566

Nov 28, 2023

Member

purplesmoke05 commented Nov 28, 2023

Related to #565

Share Update param schema should also be fixed, but I had left it as it is in [BUG] API validation for float value in token issue/update input may cause unexpected error #565. Now fixed them in this PR.


          Fix floating-point arithmetic in share params validation

e1c9180

purplesmoke05 requested a review from YoshihitoAso

November 28, 2023 13:39

purplesmoke05 marked this pull request as ready for review

November 28, 2023 13:39

YoshihitoAso approved these changes

View reviewed changes


          fix unit test

99cba48

purplesmoke05 merged commit 1ad67e7 into dev-23.12

4 checks passed

purplesmoke05 deleted the fix/#566 branch

November 28, 2023 14:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet