Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store investor personal information when approving transfer #556

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

YoshihitoAso
Copy link
Member

@YoshihitoAso YoshihitoAso commented Nov 8, 2023

close #555

1. Changes to reference API

  • No changes to list reference API interface
  • Added return items to detailed reference API

2. Personal information to be returned

  • Before approval/cancellation operations, the latest personal information will be returned.
  • After the approval/cancellation operation, the personal information at the time of the operation will be returned.

@YoshihitoAso YoshihitoAso marked this pull request as ready for review November 8, 2023 04:23
Comment on lines +58 to +70
class OperationNotAllowedStateError(AppError):
"""
Error returned when server-side data is not ready to process the request
"""

status_code = status.HTTP_400_BAD_REQUEST
code_list = [
101, # Transfer approval operations cannot be performed for accounts that do not have personal information registered.
]

def __init__(self, code: int, message: str = None):
self.code = code
super().__init__(message)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a generic error to indicate that the data state is not ready for update operations.

Copy link
Member

@purplesmoke05 purplesmoke05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshihitoAso YoshihitoAso merged commit bd19310 into dev-23.12 Nov 8, 2023
4 checks passed
@YoshihitoAso YoshihitoAso deleted the feature/#555 branch November 8, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Store personal_information at the time transfer application is approved
2 participants