Record token update operation caused by scheduled event as history #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purplesmoke05
commented
Sep 22, 2023
| _update_data = IbetStraightBondUpdateParams(**_event.data) | ||
| IbetStraightBondContract(_event.token_address).update( | ||
| data=_update_data, | ||
| tx_from=_event.issuer_address, | ||
| private_key=private_key, | ||
| ) | ||
| self.__sink_on_token_update_operation_log( |
There was a problem hiding this comment.
Changed to record token update operation caused by scheduled event as history.
purplesmoke05
commented
Sep 22, 2023
| @@ -53,10 +56,9 @@ class TestProcessor: | |||
| # Normal Case | |||
| ########################################################################### | |||
|
|
|||
| # <Normal_1_1> | |||
There was a problem hiding this comment.
Normal_1_1 and Normal_1_2 were completely duplicated, so deleted Normal_1_2.
purplesmoke05
commented
Sep 22, 2023
Comment on lines
-278
to
-281
| # <Normal_2_1> | ||
| # <Normal_2> | ||
| # IbetShare | ||
| # unset additional info | ||
| def test_normal_2_1(self, processor, db): |
There was a problem hiding this comment.
Normal_2_1 and Normal_2_2 were completely duplicated, so deleted Normal_2_2.
YoshihitoAso
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #538