Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token history API #518

Merged
merged 2 commits into from
May 2, 2023
Merged

feat: add token history API #518

merged 2 commits into from
May 2, 2023

Conversation

purplesmoke05
Copy link
Member

Close: #510

Changes

  • API
    • GET: /bond/{token_address}/history
      • Added
    • GET: /share/{token_address}/history
      • Added
  • DB
    • update_token.original_contents: column added

@purplesmoke05 purplesmoke05 self-assigned this May 1, 2023
Comment on lines +586 to +587
if data.dict(exclude_none=True) == {}:
return
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If there are no changes in query, we do nothing in this function and return immediately.

Comment on lines +40 to +41
# original contents
original_contents = Column(JSON, nullable=True)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Column added.

@purplesmoke05 purplesmoke05 marked this pull request as ready for review May 1, 2023 11:21
@YoshihitoAso YoshihitoAso merged commit 9be57a1 into dev-23.6 May 2, 2023
@YoshihitoAso YoshihitoAso deleted the feature/#510 branch May 2, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Store token attribute changed history as UpdateToken and add API endpoint
2 participants