Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint check with isort and black #490

Merged
merged 6 commits into from
Mar 8, 2023
Merged

lint check with isort and black #490

merged 6 commits into from
Mar 8, 2023

Conversation

purplesmoke05
Copy link
Member

  • Introduced black/isort as fmt tool.
  • CI only performs black lint checks.

Ref: BoostryJP/ibet-Wallet-API#1351

migrations/env.py Fixed Show fixed Hide fixed
Comment on lines +109 to +114
if "get_db_schema())" not in new_line:
# Set schema of migration exec-environment
if 'schema=' not in new_line:
new_line = re.sub('\)$', ', schema=get_db_schema())', line)
if "schema=" not in new_line:
new_line = re.sub("\)$", ", schema=get_db_schema())", line)
else: # If local environment has a schema set
new_line = re.sub('schema=(.|\s)*\)$', 'schema=get_db_schema())', line)
new_line = re.sub("schema=(.)*\)$", "schema=get_db_schema())", line)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed regular expressions according to CodeQL warnings.

@purplesmoke05 purplesmoke05 marked this pull request as ready for review March 8, 2023 00:01
@purplesmoke05 purplesmoke05 self-assigned this Mar 8, 2023
@YoshihitoAso YoshihitoAso added the enhancement New feature or request label Mar 8, 2023
@YoshihitoAso YoshihitoAso merged commit 237ec2e into dev-23.3 Mar 8, 2023
@YoshihitoAso YoshihitoAso deleted the feature/black branch March 8, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants