Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace pip with poetry #486

Merged
merged 3 commits into from
Mar 2, 2023
Merged

feat: replace pip with poetry #486

merged 3 commits into from
Mar 2, 2023

Conversation

purplesmoke05
Copy link
Member

Close: #485

@purplesmoke05 purplesmoke05 self-assigned this Mar 2, 2023
pyproject.toml Outdated
Comment on lines 9 to 27
[tool.poetry.dependencies]
python = "3.10.4"
alembic = "~1.9.4"
boto3 = "~1.26.82"
coincurve = "~18.0.0"
eth-keyfile = "0.5.1"
eth-utils = "1.10.0"
fastapi = "~0.92.0"
gunicorn = "~20.1.0"
orjson = "~3.8.7"
psycopg = {extras = ["binary"], version = "~3.1.8"}
pycryptodome = "~3.17"
pydantic = "~1.10.5"
pytz = "~2022.7.1"
requests = "~2.28.2"
shared-memory-dict = "~0.7.2"
uvicorn = "~0.20.0"
web3 = "~5.31.3"
sqlalchemy = "^2.0.4"
Copy link
Member Author

@purplesmoke05 purplesmoke05 Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Deleted PyMySQL==1.0.2 in requirements.txt.
  • Set ^ to sqlalchemy according to requirements.txt.
  • Set ~ to all packages excluding sqlalchemy/eth-keyfile/eth-utils

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong about sqlalchemy version constraints.
The correct is sqlalchemy = "~2.0.4" because of SQLAlchemy>=2.0,<2.1 (not SQLAlchemy>=2.0,<3.0).
Fixed in 94f27ac

pyproject.toml Outdated
@@ -0,0 +1,38 @@
[tool.poetry]
name = "ibet-prime"
version = "22.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23.3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced version = "23.3.0" with version = "23.3" in 905e075.

@purplesmoke05 purplesmoke05 marked this pull request as ready for review March 2, 2023 04:35
@purplesmoke05 purplesmoke05 merged commit 66338fd into dev-23.3 Mar 2, 2023
@purplesmoke05 purplesmoke05 deleted the feature/poetry branch March 2, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Use poetry as dependency management tool
2 participants