feat: store source event data as idx_transfer #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purplesmoke05
commented
Jan 17, 2023
Comment on lines
+26
to
+32
| # NOTE: Manually modified | ||
| # 1. Added server_default arg to migrate existing record. | ||
| # 2. Added alter column operation to remove server default setting. | ||
| op.add_column('idx_transfer', sa.Column('source_event', sa.String(length=50), server_default='Transfer', nullable=False), schema=get_db_schema()) | ||
| op.alter_column('idx_transfer', 'source_event', | ||
| existing_type=sa.String(length=50), | ||
| existing_nullable=False, server_default=None, schema=get_db_schema()) |
There was a problem hiding this comment.
Manually modified so as to fill Transfer value to source_event column.
YoshihitoAso
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #465
Changes
IDXTransferindexer_Transferso that source event data is stored./bond/transfers/{token_address}and/share/transfers/{token_address}Check List