feat: Make contract class object-oriented #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshihitoAso
commented
Jan 11, 2023
Comment on lines
451
to
+466
| # When using the cache | ||
| if TOKEN_CACHE: | ||
| token_cache: TokenCache = db_session.query(TokenCache). \ | ||
| filter(TokenCache.token_address == contract_address). \ | ||
| filter(TokenCache.token_address == self.token_address). \ | ||
| first() | ||
| if token_cache is not None: | ||
| is_updated = IbetStraightBondContract.check_attr_update( | ||
| is_updated = self.check_attr_update( | ||
| db_session=db_session, | ||
| contract_address=contract_address, | ||
| base_datetime=token_cache.cached_datetime | ||
| ) | ||
| if is_updated is False and token_cache.expiration_datetime > datetime.utcnow(): | ||
| # Get data from cache | ||
| bond_token = IbetStraightBondContract() | ||
| for k, v in token_cache.attributes.items(): | ||
| setattr(bond_token, k, v) | ||
| setattr(self, k, v) | ||
| db_session.close() | ||
| return bond_token | ||
| return AttributeDict(self.__dict__) |
There was a problem hiding this comment.
As a byproduct of this refactoring, the get() now returns only properties instead of the contract class itself.
YoshihitoAso
commented
Jan 11, 2023
purplesmoke05
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current contract classes (model layer for blockchain) is stateless, where the contract address is entered for each function execution, but this is difficult for developers to understand, so I refactored them.