Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added locked balance #454

Merged
merged 2 commits into from
Jan 6, 2023
Merged

feat: Added locked balance #454

merged 2 commits into from
Jan 6, 2023

Conversation

YoshihitoAso
Copy link
Member

@YoshihitoAso YoshihitoAso commented Jan 5, 2023 •
edited
Loading

#448

(1) Added TBL and fixed indexer

  • TBL: idx_locked_position
  • Indexer
    • indexer_position_bond
    • indexer_position_share

(2) Added locked amount to the return item

  • GET: /bond/tokens/{token_address}/holders
  • GET: /bond/tokens/{token_address}/holders/{account_address}
  • GET: /share/tokens/{token_address}/holders
  • GET: /share/tokens/{token_address}/holders/{account_address}
  • GET: /positions/{account_address}
  • GET: /positions/{account_address}/{token_address}

(3) Changes to conditions for count calculation

  • GET: /bond/tokens/{token_address}/holders/count
  • GET: /share/tokens/{token_address}/holders/count

@YoshihitoAso YoshihitoAso marked this pull request as ready for review January 5, 2023 14:33
@YoshihitoAso YoshihitoAso changed the title feat: Add locked balance feat: Added locked balance Jan 5, 2023
purplesmoke05
purplesmoke05 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@purplesmoke05 purplesmoke05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshihitoAso YoshihitoAso merged commit a9f2011 into dev-23.3 Jan 6, 2023
@YoshihitoAso YoshihitoAso deleted the feature/#448_1 branch January 6, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplesmoke05 purplesmoke05 purplesmoke05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoshihitoAso @purplesmoke05