Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade FastAPI #389

Merged
merged 2 commits into from
Sep 16, 2022
Merged

fix: upgrade FastAPI #389

merged 2 commits into from
Sep 16, 2022

Conversation

purplesmoke05
Copy link
Member

@purplesmoke05 purplesmoke05 commented Sep 16, 2022

Close: #387

This is specific to unit testing.

  • デフォルトのRequest の状態が2つのバージョン間で若干変わっています。
    • Starlette 0.17.1ではIP/ポート情報がデフォルト値としてセットされます。
    • Starlette 0.20.4ではRequestに対してhost/portの引数を渡さない場合、IP/ポート情報がセットされません。

これはユニットテスト特有の事象です。

@YoshihitoAso YoshihitoAso merged commit 0722f28 into dev-22.9 Sep 16, 2022
@YoshihitoAso YoshihitoAso deleted the feature/#387 branch September 16, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE Upgrade FastAPI
2 participants