Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] require_personal_info_registered is not set properly when token contract is issued #619

Closed
purplesmoke05 opened this issue Apr 18, 2024 · 0 comments · Fixed by #621
Assignees
Labels
bug Something isn't working

Comments

@purplesmoke05
Copy link
Member

Describe the bug

  • require_personal_info_registered is not set properly when token contract is issued.

if token_type == TokenType.IBET_SHARE.value:
update_data = {
"tradable_exchange_contract_address": arguments.get(
"tradable_exchange_contract_address"
),
"personal_info_contract_address": arguments.get(
"personal_info_contract_address"
),
"transferable": arguments.get("transferable"),
"status": arguments.get("status"),
"is_offering": arguments.get("is_offering"),
"contact_information": arguments.get("contact_information"),
"privacy_policy": arguments.get("privacy_policy"),
"transfer_approval_required": arguments.get(
"transfer_approval_required"
),
"is_canceled": arguments.get("is_canceled"),
}
return IbetShareUpdateParams(**update_data)
elif token_type == TokenType.IBET_STRAIGHT_BOND.value:
update_data = {
"face_value_currency": arguments.get("face_value_currency"),
"redemption_value_currency": arguments.get(
"redemption_value_currency"
),
"interest_rate": arguments.get("interest_rate"),
"interest_payment_date": arguments.get("interest_payment_date"),
"interest_payment_currency": arguments.get(
"interest_payment_currency"
),
"base_fx_rate": arguments.get("base_fx_rate"),
"transferable": arguments.get("transferable"),
"status": arguments.get("status"),
"is_offering": arguments.get("is_offering"),
"is_redeemed": arguments.get("is_redeemed"),
"tradable_exchange_contract_address": arguments.get(
"tradable_exchange_contract_address"
),
"personal_info_contract_address": arguments.get(
"personal_info_contract_address"
),
"contact_information": arguments.get("contact_information"),
"privacy_policy": arguments.get("privacy_policy"),
"transfer_approval_required": arguments.get(
"transfer_approval_required"
),
}
return IbetStraightBondUpdateParams(**update_data)

  • This is because the processor of update token attributes does not pass the parameter of require_personal_info_registered to blockchain model.

Expected behavior

  • require_personal_info_registered is set properly when token contract is issued.
@purplesmoke05 purplesmoke05 added the bug Something isn't working label Apr 18, 2024
@purplesmoke05 purplesmoke05 self-assigned this Apr 18, 2024
YoshihitoAso added a commit that referenced this issue Apr 19, 2024
Fixed to update token attributes of `require_personal_info_registered`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant