Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] missing error handling for contract revert error #380

Closed
purplesmoke05 opened this issue Sep 2, 2022 · 0 comments · Fixed by #381
Closed

[BUG] missing error handling for contract revert error #380

purplesmoke05 opened this issue Sep 2, 2022 · 0 comments · Fixed by #381
Assignees
@purplesmoke05
Labels
bug Something isn't working

Comments

@purplesmoke05
Copy link
Member

purplesmoke05 commented Sep 2, 2022 •
edited
Loading

Describe the bug

Some batch requires handling exception thrown when contract reverts.

e.g.)

  • processor_batch_issue_redeem.py
  • processor_rotate_e2e_messaging_rsa_key.py
  • processor_scheduled_events.py

コントラクトリバート例外発生時のハンドリングが必要なバッチが存在する。

Expected behavior

catch ContractRevertError and handle properly in batch.

バッチ内でContractRevertErrorをキャッチし、適切にハンドリングを行う。
@purplesmoke05 purplesmoke05 added the bug Something isn't working label Sep 2, 2022
@purplesmoke05 purplesmoke05 self-assigned this Sep 2, 2022
@purplesmoke05 purplesmoke05 mentioned this issue Sep 2, 2022
Merged
YoshihitoAso added a commit that referenced this issue Sep 2, 2022
@YoshihitoAso
Merge pull request #381 from BoostryJP/fix/#380
c9d629c 
fix: add error handling for contract revert error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@purplesmoke05 purplesmoke05

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add error handling for contract revert error BoostryJP/ibet-Prime
1 participant
@purplesmoke05