Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Langdal/review #97

Merged
merged 11 commits into from
Sep 9, 2021
Merged

Langdal/review #97

merged 11 commits into from
Sep 9, 2021

Conversation

langdal
Copy link
Member

@langdal langdal commented Sep 8, 2021 •
edited
Loading

CSV import/export functionality code review response

  • Moved buttons to stand alone component that can be inserted anywhere, DownloadCSVButton and UploadCSVButton
  • CSV convertion functions moved together with other common utilities
  • Unit tests added for CSV conversion

Outstanding tasks

  • Make the DataPoints table update when the data points are added through experiment::dispatch
  • Add spacing between buttons and maybe change style to be more subtle
  • Make score array work on upload

@langdal langdal merged commit a4d6a6c into feature/bulk_data_import_export Sep 9, 2021
@j-or j-or deleted the langdal/review branch September 16, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkselObdrup AkselObdrup Awaiting requested review from AkselObdrup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langdal @j-or