Feature/discrete continuous simple #85
Conversation
# Conflicts: # components/optimizer-configurator.tsx # components/optimizer-model.tsx
types/common.ts
Outdated
| name: string | ||
| description: string | ||
| minVal: number | ||
| maxVal: number | ||
| minVal: string |
There was a problem hiding this comment.
I think we should try to preserve the type as number and rely on the "discrete" flag
There was a problem hiding this comment.
The text field returns a string to useForm (even with type="number") and in this simple version the discrete flag is set by checking for "." in the string. You can force useForm to return a number but 1.0 becomes 1 before the check, so I'm not sure how we would check for that without having the explicitly set "discrete" option from the UI. So... maybe change it back to number, when we make the better version with an option to set it from the UI?
There was a problem hiding this comment.
Agreed - we should change it back when discrete becomes an explicit option
|
Moved next experiments to always be above data points
|
… add empty plots card
No description provided.