Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dropzone SVG icon does not apply style in production #35 #60

Merged
merged 3 commits into from
May 12, 2021

Conversation

j-or
Copy link
Contributor

@j-or j-or commented May 12, 2021

No description provided.

@j-or j-or linked an issue May 12, 2021 that may be closed by this pull request
@j-or j-or changed the title Override icon style, load default if theme not found The dropzone SVG icon does not apply style in production #35 May 12, 2021
@j-or
Copy link
Contributor Author

j-or commented May 12, 2021

I'd have preferred not using !important to fix the issue but the solution given here https://material-ui.com/styles/advanced/#css-injection-order did not work. #61 has been created in case the general issue needs more attention.

@j-or
Copy link
Contributor Author

j-or commented May 12, 2021

This PR also cleans up theming a bit and loads a default theme if the current one is not found.

@j-or j-or requested a review from langdal May 12, 2021 15:08
Copy link
Member

@langdal langdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building the docker image fails for this branch.
The reported error is:
#11 59.76 Failed to compile. #11 59.76 #11 59.76 ./reducers/global-reducer.ts:37:5 #11 59.76 Type error: Type '"blueGreenTheme"' is not assignable to type 'ThemeName'. #11 59.76 #11 59.76 35 | debug: false, #11 59.76 36 | experimentsInLocalStorage: [], #11 59.76 > 37 | theme: "blueGreenTheme" #11 59.76 | ^ #11 59.76 38 | } #11 59.76 39 | #11 59.76 40 | export const reducer = (state: State, action: Action) => {

@j-or j-or merged commit 62c220c into main May 12, 2021
@j-or j-or deleted the bug/missing_dropzone_icon_style branch May 12, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dropzone SVG icon does not apply style in production
2 participants