Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update button from config, hide dirty state when using local s… #43

Merged
merged 3 commits into from
May 10, 2021

Conversation

j-or
Copy link
Contributor

@j-or j-or commented May 10, 2021

…torage

@j-or j-or self-assigned this May 10, 2021
@j-or j-or requested a review from langdal May 10, 2021 13:32
@@ -11,7 +11,12 @@ import React, { useState, useEffect } from 'react';
import { ValueVariableType, CategoricalVariableType, OptimizerConfig, DataPointType } from '../types/common';
import LoadingExperiment from './loading-experiment';

export default function Experiment() {
type ExperimentProps = {
useLocalStorage: boolean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burde den ikke hedde noget i stil med allowSaveToServer?

@j-or j-or merged commit 47652c5 into main May 10, 2021
@j-or j-or deleted the feature/local_storage_mode branch May 10, 2021 14:10
@j-or j-or linked an issue May 11, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust experiment page when in local storage mode
2 participants