Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/editable data points #24

Merged
merged 26 commits into from
Apr 28, 2021
Merged

Feature/editable data points #24

merged 26 commits into from
Apr 28, 2021

Conversation

j-or
Copy link
Contributor

@j-or j-or commented Apr 26, 2021

No description provided.

This was linked to issues Apr 26, 2021
Option to edit data point values (experiment results) #7
Closed
Add dropdown for categorical variable data points #23
Closed
@j-or j-or requested a review from langdal April 27, 2021 12:33
langdal
langdal requested changes Apr 27, 2021
View reviewed changes
Copy link
Member

@langdal langdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

One issue that should probably be fixed before merging is when clicking on the "X" in the new data point line it dissapears and there are no way to get the line back.

reducers/reducers.ts Outdated Show resolved Hide resolved
@j-or
Copy link
Contributor Author

j-or commented Apr 28, 2021

Looks good overall.

One issue that should probably be fixed before merging is when clicking on the "X" in the new data point line it dissapears and there are no way to get the line back.

Agreed, thanks. Disappearing row now fixed and test added that covers the scenario.

@j-or j-or merged commit 4b046eb into main Apr 28, 2021
@j-or j-or deleted the feature/editable_data_points branch April 28, 2021 08:58
@langdal langdal mentioned this pull request Apr 29, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langdal langdal langdal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dropdown for categorical variable data points Option to edit data point values (experiment results)
2 participants
@j-or @langdal