Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add "Create or Overwrite experiment" dialog #147

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

lasseborly
Copy link
Contributor

Whenever you try to upload an experiment that already exists we prompt the user with a dialog, asking them to pick if the experiment should be overwritten or create a new experiment with the same data.

@lasseborly lasseborly linked an issue Mar 30, 2022 that may be closed by this pull request
@lasseborly lasseborly requested a review from langdal March 30, 2022 13:19
@lasseborly lasseborly self-assigned this Mar 30, 2022
@lasseborly lasseborly added the enhancement New feature or request label Mar 30, 2022
@lasseborly lasseborly changed the title Add "Create or Overwrite experiment" dialog Feature/Add "Create or Overwrite experiment" dialog Mar 30, 2022
@lasseborly lasseborly changed the title Feature/Add "Create or Overwrite experiment" dialog Feature/add "Create or Overwrite experiment" dialog Mar 30, 2022
Copy link
Member

@langdal langdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Looks like you haven't installed the newly introduced commit hook that will run prettier on each commit.
I have applied yarn prettier --write . to the branch

@lasseborly
Copy link
Contributor Author

Hmm was pretty sure that I had the format on save turned on.. Had not apparently. Will rebase and merge tomorrow.

Whenever you try to upload an experiment that already exists we prompt the user with a dialog, asking them to pick if the experiment should be overwritten or create a new experiment with the same data.
@lasseborly lasseborly force-pushed the feature/copy-or-overwrite-experiment branch from a156383 to 1020a8d Compare March 31, 2022 05:36
@lasseborly lasseborly merged commit df69373 into main Mar 31, 2022
@langdal langdal deleted the feature/copy-or-overwrite-experiment branch March 31, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy or overwrite experiment
2 participants