Accept expected_minimum in JSON result #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps://github.com/BoostV/process-optimizer-frontend into feature/expose-expected_minimum-in-the-frontend # Conflicts: # components/next-experiments/next-experiments.tsx
j-or
approved these changes
Sep 24, 2021
utility/migration/migration.test.ts
Outdated
| }) | ||
|
|
||
| it("should migrate to 4 from 3 (expectedMinimum added to result)", () => { | ||
| expect(migrate(version2, "4")).toEqual(version4) |
There was a problem hiding this comment.
Shouldn't this be migrate(3, 4)?
| json = migration.converter(json) | ||
| const migrationIndex = MIGRATIONS.findIndex(m => m === migration) | ||
| const isLastMigration = migrationIndex === MIGRATIONS.length - 1 | ||
| const isLastMigration = migrationIndex === MIGRATIONS.length - 1 || migration.version === stopAtVersion |
There was a problem hiding this comment.
Can migrationIndex === MIGRATIONS.length - 1 be removed now that there is a stopAtVersion with a default?
There was a problem hiding this comment.
Yes it could be removed, however, I think it would be better to keep it to prevent errors where a user enters a non-existing stopVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose expected minimum in frontend
This PR depends on BoostV/process-optimizer-api#26 being merged and that the API project version is bumped to 1.4.0
The structure of the expectedMinimum entry is like this:
Closes #106