Merge pull request #173 from BoostV/159-number-of-initial-experiments…

…-should-be-dynamically-calculated 159 number of initial experiments should be dynamically calculated
BoostV · Jul 6, 2022 · 2182976 · 2182976
2 parents 454f32f + f359680
commit 2182976
Show file tree

Hide file tree

Showing 3 changed files with 268 additions and 157 deletions.
diff --git a/src/components/result-data/result-data.tsx b/src/components/result-data/result-data.tsx
@@ -38,6 +38,7 @@ export const ResultData = (props: ResultDataProps) => {
     (experiment.extras['experimentSuggestionCount'] as number) ?? 1
 
   const isInitializing =
+    experiment.optimizerConfig.initialPoints === 0 ||
     experiment.dataPoints.length < experiment.optimizerConfig.initialPoints
   const summary = isInitializing ? (
     <InitializationProgress />

diff --git a/src/reducers/experiment-reducers.ts b/src/reducers/experiment-reducers.ts
@@ -10,6 +10,12 @@ import {
 import { assertUnreachable } from '../utility'
 import produce from 'immer'
 
+const calculateInitialPoints = (state: ExperimentType) =>
+  Math.max(
+    3,
+    (state.categoricalVariables.length + state.valueVariables.length) * 3
+  )
+
 export type ExperimentAction =
   | {
       type: 'setSwVersion'
@@ -91,11 +97,17 @@ export const experimentReducer = produce(
           0,
           action.payload
         )
+        state.optimizerConfig.initialPoints = calculateInitialPoints(state)
+        state.extras.experimentSuggestionCount =
+          state.optimizerConfig.initialPoints
         break
       case 'deleteValueVariable':
         state.changedSinceLastEvaluation = true
         let indexOfDelete = state.valueVariables.indexOf(action.payload)
         state.valueVariables.splice(indexOfDelete, 1)
+        state.optimizerConfig.initialPoints = calculateInitialPoints(state)
+        state.extras.experimentSuggestionCount =
+          state.optimizerConfig.initialPoints
         break
       case 'addCategorialVariable':
         state.changedSinceLastEvaluation = true
@@ -104,13 +116,19 @@ export const experimentReducer = produce(
           0,
           action.payload
         )
+        state.optimizerConfig.initialPoints = calculateInitialPoints(state)
+        state.extras.experimentSuggestionCount =
+          state.optimizerConfig.initialPoints
         break
       case 'deleteCategorialVariable':
         state.changedSinceLastEvaluation = true
         let indexOfCatDelete = state.categoricalVariables.indexOf(
           action.payload
         )
         state.categoricalVariables.splice(indexOfCatDelete, 1)
+        state.optimizerConfig.initialPoints = calculateInitialPoints(state)
+        state.extras.experimentSuggestionCount =
+          state.optimizerConfig.initialPoints
         break
       case 'updateConfiguration':
         state.changedSinceLastEvaluation = true