Add tag link handling with :tag:#tag syntax

[AWolf81]

Description

I've added the tag links by using :tag:#tag link syntax.
It's working but not ready for merge because I'd like to wait for React upgrade because I'm using hashHistory directly. This will be changed later to dispatch(push(...))

Issue fixed

#1683

Type of changes

• ⚪ Bug fix (Change that fixed an issue)
• ⚪ Breaking change (Change that can cause existing functionality to change)
• ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
• 🔘 Feature (Change that adds new functionality)
• ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

• 🔘 My code follows the project code style
• ⚪ I have written test for my code and it has been tested
• ⚪ All existing tests have been passed
• 🔘 I have attached a screenshot/video to visualize my change if possible --> see issue

Note

The tag links are not handled in editor just in MarkdownPreview and I think we should open a new issue for this as I think the other link types (:line) are also not handled - or is line & tag handling only required in preview? I think they should be handled as there is a tooltip indicating how to click but the click is not working.

[ZeroX-DG]

Very nice, this works very good for me. @AWolf81 can you resolve the conflict before I can approve it?

[AWolf81]

@ZeroX-DG sure, I've resolved the conflict and checked the feature.

I'll open an issue (if it's not already in the issues) for the Crtl+Link click that's not working for tag and line links as mentioned in my note above.

Update:
Travis CI fixed.
I've found the issue with linting in my editor. It was caused by my VS code setting. It used VS code standard format extension instead of eslint/prettier. (It added me a space before every paren)
My .vscode/settings.json looks like this (added formatOnSave and the eslint part)

{
  "editor.tabSize": 2,
  "search.exclude": {
    "**/node_modules": true
  },
  "typescript.validate.enable": false,
  "javascript.validate.enable": false,
  "[javascript]": {
    "editor.formatOnSave": true
  },
  "editor.codeActionsOnSave": {
    // For ESLint
    "source.fixAll.eslint": true,
  },
  "git.ignoreLimitWarning": true
}

[ZeroX-DG]

LGTM 🎉

[Rokt33r]

@AWolf81 @ZeroX-DG I don't think we need to keep #. :tag:tag should be enough. How do you think?

[ZeroX-DG]

That could be a good idea. Keep the consistency with other type of links like :note: or :line:. I'm OK with either way so @AWolf81 what do you think about this?

[AWolf81]

I would keep it with the hash as it's easier to remember and I think it would be confusing to users. As the tag is always displayed with the # in front.
The consistency would be better and it's an easy change - just removing the hash from the Regex.

Maybe if there would be a context menu to add tag links we could do it with-out #. But we should create an issue for this and discuss it there e.g. right click on tag shows Insert link to tag.

[Rokt33r]

@AWolf81

I think prefixing :tag: is already enough to prevent the confusing. So yeah, I want to keep consistency so users can expect same behavior of other internal links. So please fix it. 🙏

Maybe if there would be a context menu to add tag links we could do it with-out #. But we should create an issue for this and discuss it there e.g. right click on tag shows Insert link to tag.

Sounds good to me but should be better to presented in a separated PR.

[AWolf81]

@Rokt33r sure. I've fixed it. 👍

For the context menu I'll create an issue and start working on it later today.

[ZeroX-DG]

LGTM 🎉