Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FAQ.md #2755

Merged
merged 4 commits into from
Dec 27, 2018
Merged

Create FAQ.md #2755

merged 4 commits into from
Dec 27, 2018

Conversation

empeje
Copy link
Contributor

@empeje empeje commented Dec 27, 2018

Description

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@empeje empeje mentioned this pull request Dec 27, 2018
Closed
Rokt33r
Rokt33r requested changes Dec 27, 2018
View reviewed changes
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one tiny change request. The contents look fine. 👍

FAQ.md Outdated Show resolved Hide resolved
@ZeroX-DG ZeroX-DG added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Dec 27, 2018
@Rokt33r Rokt33r added next release (v0.11.13) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Dec 27, 2018
@empeje
Copy link
Contributor Author

empeje commented Dec 27, 2018

Cool 👍

@Rokt33r Rokt33r merged commit 05da826 into BoostIO:master Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rokt33r Rokt33r Rokt33r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@empeje @Rokt33r @ZeroX-DG