Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] - 1638 - Support for admonitions #1987

Merged
merged 1 commit into from
May 28, 2018

Conversation

johannbre
Copy link
Contributor

Added support for markup admonitions by including markdown-it-admonition. Added material icon support and updates to styles for the rendering of six different types of admonitions.

admonitions

admonitions

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label May 27, 2018
@sosukesuzuki sosukesuzuki self-requested a review May 28, 2018 01:39
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I noticed that you forgot running yarn after approved.
please commit yarn.lock.

@kazup01 kazup01 added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels May 28, 2018
Added support for markup admonitions by including markdown-it-admonition. Added material icon support and updates to styles for rendering of six different types of admonitions.
@johannbre
Copy link
Contributor Author

Committed and pushed

@sosukesuzuki sosukesuzuki merged commit 8e74ee7 into BoostIO:master May 28, 2018
@sosukesuzuki sosukesuzuki removed the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label May 28, 2018
@TobseF
Copy link

TobseF commented Jun 15, 2018

Doesn't work on Windows if the Material Icon font isn't installed.
#2083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants