Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1788 #1860

Closed
wants to merge 3 commits into from
Closed

Issue1788 #1860

wants to merge 3 commits into from

Conversation

ehhc
Copy link
Contributor

@ehhc ehhc commented Apr 23, 2018

This change is based on the refactoring done in #1852

@Rokt33r
Copy link
Member

Rokt33r commented Apr 26, 2018

Same to #1857. Please close this pr and create another one.

@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 26, 2018
@ehhc ehhc closed this Apr 27, 2018
@ehhc ehhc deleted the Issue1788 branch April 27, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants