Properly decoding for the title of pasted website #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I surprise that yahoo is still using |
|
yeah I surprised too.. Thank you for your review! |
Rokt33r
added
next release (v0.11.0)
and removed
awaiting review ❇️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we paste the URL, the title of the website is automatically fetched, but if it was encoded by non-utf8 encoding it could not be decoded correctly and it garbled.
My proposal
Check the
Content-Typeheader of the HTTP response when fetching the website from the URL, and if thecharsetis specified, decode response with iconv as that charset before getting title.If
charsetis not specified or not supported, the response will be decoded as utf-8.before
after