-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage labels to 'All Notes' and figure a better solution to the dull storage notes list view #1556
Add storage labels to 'All Notes' and figure a better solution to the dull storage notes list view #1556
Conversation
Added storage labelings to 'All Notes' in Default and Compressed views
Updated:When in "All notes" view, note items will display their storage names Note items do not display any folder/storage when clicking on any individual notes in the side nav (because it is redundant) @nlopin How about this? |
@pfftdammitchris I'm not the one who is asked, but I like this. 👍 |
Looks great! How does it look if the title of a note is long? |
@Rokt33r thanks :) hearing that definitely motivates me to provide more help to the project since I feel assured that I am going in the right directions! Also, I'm thinking to probably provide the user the option in the preferences to show the colors of the folders when viewing the storage only. I think that is better than the gray dull coloring (whereas it is ok for viewing "all notes") What do you guys think? |
It can be done with
You can use
I don't mind if there are options to choose, but I like the gray dull coloring. It looks clean and calm. 😌 😌 |
…re no longer overflowing nearby elements
Got that in. Ok, I think the pull request should be complete now. I was deciding whether to continue progressing the color ideas but I can make a separate pull request for that. This pull request is pretty important IMO so we should get this into the next version first |
Edit 02/20/2018 : Will progress this pull request fully this coming weekend (Fri/sat/sun) for sure
Edit 02/19/2018: I think I am going to also proceed to the storage view and implement some color labeling to storage view. So this pull request isn't finished yet
Added storage labelings to 'All Notes' (this serves as a starting point for building the rest of #1545)
Works for:
Previously when we were viewing notes in the All Notes view, we could not tell which storage the notes came from. This was confusing to the user. So we need a way to show to the user which storage the notes are in. This pull request provides storage labels to solve that as shown in the screenshot below
This is a re-make in reference to #1551 and originated from #1545 without any color integration implemented, with the purpose of serving as a starting point
I re-made the pull request to make this more simple because the previous pull request had unrelated changes (it barged into the folder labelings when this was originated for storage labelings)
I tried to keep it as simple as possible, without breaking any code.
Screenshot:
TODOS: